Skip to content

Fix assign_coords resetting all dimension coords to default index#7347

Merged
dcherian merged 4 commits into
pydata:mainfrom
benbovy:fix-assign-coords-custom-indx
Dec 2, 2022
Merged

Fix assign_coords resetting all dimension coords to default index#7347
dcherian merged 4 commits into
pydata:mainfrom
benbovy:fix-assign-coords-custom-indx

Conversation

@benbovy

@benbovy benbovy commented Dec 2, 2022

Copy link
Copy Markdown
Member

@benbovy

benbovy commented Dec 2, 2022

Copy link
Copy Markdown
Member Author

@dcherian we can merge this after #7345 to make things easier for the release?

@dcherian

dcherian commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

Looks like a nice fix (and low risk) to me!

@dcherian dcherian merged commit 8938d39 into pydata:main Dec 2, 2022
@benbovy

benbovy commented Dec 2, 2022

Copy link
Copy Markdown
Member Author

Great! (I was worried that it would mess up #7345).

dcherian added a commit to dcherian/xarray that referenced this pull request Dec 8, 2022
* main:
  absolufy-imports - No relative imports - PEP8 (pydata#7204)
  [skip-ci] whats-new for dev (pydata#7351)
  Whats-new: 2022.12.0 (pydata#7345)
  Fix assign_coords resetting all dimension coords to default index (pydata#7347)
@benbovy benbovy deleted the fix-assign-coords-custom-indx branch December 8, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

assign_coords reset all dimension coords to default (pandas) index

2 participants